Skip to content

upgrading tokio to 1.52.1#5256

Open
zbowling wants to merge 1 commit intofacebook:mainfrom
zbowling:export-D101580193
Open

upgrading tokio to 1.52.1#5256
zbowling wants to merge 1 commit intofacebook:mainfrom
zbowling:export-D101580193

Conversation

@zbowling
Copy link
Copy Markdown
Contributor

Reviewed By: dtolnay

Differential Revision: D101580193

Reviewed By: dtolnay

Differential Revision: D101580193
Copilot AI review requested due to automatic review settings April 20, 2026 23:56
@meta-cla meta-cla Bot added the CLA Signed label Apr 20, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 20, 2026

@zbowling has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101580193.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Rust compiler workspace’s Tokio dependency version to keep async runtime behavior and APIs aligned across crates.

Changes:

  • Bump tokio from 1.50.0 to 1.52.1 across multiple compiler/crates/* Cargo.toml files (primarily in dev-dependencies).

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
compiler/crates/schema/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for schema crate tests/tools.
compiler/crates/schema-validate/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for schema validation tests.
compiler/crates/schema-print/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for schema printing tests.
compiler/crates/relay-typegen/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for typegen tests.
compiler/crates/relay-transforms/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for transforms tests.
compiler/crates/relay-schema-generation/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for schema generation tests.
compiler/crates/relay-lsp/Cargo.toml Bumps Tokio dependency to 1.52.1 for LSP runtime/tests.
compiler/crates/relay-docblock/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for docblock tests.
compiler/crates/relay-compiler/Cargo.toml Bumps Tokio dependency to 1.52.1 for compiler runtime/tests.
compiler/crates/relay-codegen/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for codegen tests.
compiler/crates/relay-bin/Cargo.toml Bumps Tokio dependency to 1.52.1 for CLI runtime/tests.
compiler/crates/graphql-text-printer/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for printer tests.
compiler/crates/graphql-syntax/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for syntax tests.
compiler/crates/graphql-ir/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for IR tests.
compiler/crates/graphql-ir-validations/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for validation tests.
compiler/crates/fixture-tests/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for test harness.
compiler/crates/extract-graphql/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for extraction tests.
compiler/crates/docblock-syntax/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for docblock syntax tests.
compiler/crates/dependency-analyzer/Cargo.toml Bumps Tokio dev-dependency to 1.52.1 for analyzer tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fixture-tests = { path = "../fixture-tests" }
graphql-cli = { path = "../graphql-cli" }
tokio = { version = "1.50.0", features = ["full", "test-util", "tracing"] }
tokio = { version = "1.52.1", features = ["full", "test-util", "tracing"] }
Copy link

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Tokio version bump will require updating compiler/Cargo.lock; CI runs cargo test --locked (see .github/workflows/ci.yml), so leaving the lockfile at Tokio 1.50.0 will cause the workflow to fail.

Suggested change
tokio = { version = "1.52.1", features = ["full", "test-util", "tracing"] }
tokio = { version = "1.50.0", features = ["full", "test-util", "tracing"] }

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants