upgrading tokio to 1.52.1#5256
Open
zbowling wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
Reviewed By: dtolnay Differential Revision: D101580193
Contributor
|
@zbowling has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101580193. |
There was a problem hiding this comment.
Pull request overview
Updates the Rust compiler workspace’s Tokio dependency version to keep async runtime behavior and APIs aligned across crates.
Changes:
- Bump
tokiofrom1.50.0to1.52.1across multiplecompiler/crates/*Cargo.tomlfiles (primarily indev-dependencies).
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| compiler/crates/schema/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for schema crate tests/tools. |
| compiler/crates/schema-validate/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for schema validation tests. |
| compiler/crates/schema-print/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for schema printing tests. |
| compiler/crates/relay-typegen/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for typegen tests. |
| compiler/crates/relay-transforms/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for transforms tests. |
| compiler/crates/relay-schema-generation/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for schema generation tests. |
| compiler/crates/relay-lsp/Cargo.toml | Bumps Tokio dependency to 1.52.1 for LSP runtime/tests. |
| compiler/crates/relay-docblock/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for docblock tests. |
| compiler/crates/relay-compiler/Cargo.toml | Bumps Tokio dependency to 1.52.1 for compiler runtime/tests. |
| compiler/crates/relay-codegen/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for codegen tests. |
| compiler/crates/relay-bin/Cargo.toml | Bumps Tokio dependency to 1.52.1 for CLI runtime/tests. |
| compiler/crates/graphql-text-printer/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for printer tests. |
| compiler/crates/graphql-syntax/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for syntax tests. |
| compiler/crates/graphql-ir/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for IR tests. |
| compiler/crates/graphql-ir-validations/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for validation tests. |
| compiler/crates/fixture-tests/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for test harness. |
| compiler/crates/extract-graphql/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for extraction tests. |
| compiler/crates/docblock-syntax/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for docblock syntax tests. |
| compiler/crates/dependency-analyzer/Cargo.toml | Bumps Tokio dev-dependency to 1.52.1 for analyzer tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fixture-tests = { path = "../fixture-tests" } | ||
| graphql-cli = { path = "../graphql-cli" } | ||
| tokio = { version = "1.50.0", features = ["full", "test-util", "tracing"] } | ||
| tokio = { version = "1.52.1", features = ["full", "test-util", "tracing"] } |
There was a problem hiding this comment.
This Tokio version bump will require updating compiler/Cargo.lock; CI runs cargo test --locked (see .github/workflows/ci.yml), so leaving the lockfile at Tokio 1.50.0 will cause the workflow to fail.
Suggested change
| tokio = { version = "1.52.1", features = ["full", "test-util", "tracing"] } | |
| tokio = { version = "1.50.0", features = ["full", "test-util", "tracing"] } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed By: dtolnay
Differential Revision: D101580193