Skip to content

fix(devtools): preserve compiler badge for nested Forget names#36481

Open
leno23 wants to merge 1 commit into
facebook:mainfrom
leno23:fix/devtools-forget-memo-badge
Open

fix(devtools): preserve compiler badge for nested Forget names#36481
leno23 wants to merge 1 commit into
facebook:mainfrom
leno23:fix/devtools-forget-memo-badge

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 16, 2026

Summary

  • detect the DevTools Forget marker when it appears inside parsed HOC wrappers, e.g. Memo(Forget(Component))
  • remove the synthetic Forget wrapper from hocDisplayNames so the existing compiler badge renders instead
  • add a focused parser regression test for memo/Forget display names

Fixes #32485.

Test Plan

  • Not run locally; API-only patch prepared without a full React checkout.
  • Added parseElementDisplayNameFromBackend unit coverage in packages/react-devtools-shared/src/__tests__/utils-test.js.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 16, 2026

Hi @leno23!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@leno23 leno23 force-pushed the fix/devtools-forget-memo-badge branch from 96e1ad0 to 3453932 Compare May 16, 2026 08:41
@leno23 leno23 marked this pull request as ready for review May 16, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DevTools Bug]: The memo component is not displayed correctly

1 participant