perf(react-dom): bound server style name cache#36479
Conversation
|
Hi @leno23! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary
This bounds the module-level
styleNameCacheused byprocessStyleNamein the React DOM server renderer.The cache normally contains a small fixed set of style property names, but it is currently unbounded for the lifetime of a long-running SSR process. This change clears the cache if it grows beyond 1024 unique keys, preserving the existing fast path for normal cases while avoiding pathological retention of unbounded user-generated style names.
Test Plan
yarn test packages/react-domNotes
I chose a simple clear-on-limit strategy instead of LRU to avoid adding per-access overhead to the hot path.