Fix ScrollView touch events ignored in contentInset area on iOS#56747
Closed
cbrevik wants to merge 1 commit into
Closed
Fix ScrollView touch events ignored in contentInset area on iOS#56747cbrevik wants to merge 1 commit into
cbrevik wants to merge 1 commit into
Conversation
|
@javache has imported this pull request. If you are a Meta employee, you can view this in D104644045. |
Collaborator
|
This pull request was successfully merged by @cbrevik in efcab20 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #54123
In RN 0.80,
betterHitTest:withEvent:inRCTScrollViewComponentViewwas added, which returnsself(theRCTScrollViewComponentViewwrapper view) when a touch point falls inside the scroll view's bounds. This causes touches in the contentInset area — where no content is rendered — to be absorbed by the wrapper rather than forwarded to the underlying UIScrollView, making scroll gestures in that region completely non-functional.The fix returns
_scrollViewinstead ofself, so hit-tested touches are correctly attributed to theUIScrollViewand scrolling works throughout the full bounds, including the inset area.Changelog:
[IOS] [FIXED] - Fix ScrollView touch events ignored in contentInset area on Fabric
Test Plan:
Couldn't use the snack-repro from #54123 since this requires a native change. But using the
ScrollViewSimpleExamplefrom the RNTester, and removing a lot of the items demonstrates the behaviour change.The two videos show attempted dragging from the region below the ScrollView content.
Before: Dragging in the inset area does nothing — scroll view does not respond
Before-fix.mov
After: Dragging in the inset area scrolls the content correctly
After-fix.mov