Skip to content

Fix Image.getSize returning downsampled dimensions on Android #56736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zoontek wants to merge 3 commits into from
+59 −62
Closed

Fix Image.getSize returning downsampled dimensions on Android #56736

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f898557
Fix Image.getSize returning downsampled dimensions on Android
zoontek May 8, 2026
e60e050
Add setRotationOptions(RotationOptions.disableRotation())
zoontek May 11, 2026
f9477bb
review
zoontek May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 59 additions & 62 deletions ...t-native/ReactAndroid/src/main/java/com/facebook/react/modules/image/ImageLoaderModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,20 @@

package com.facebook.react.modules.image

import android.media.ExifInterface
import android.net.Uri
import android.util.SparseArray
import com.facebook.common.executors.CallerThreadExecutor
import com.facebook.common.memory.PooledByteBuffer
import com.facebook.common.references.CloseableReference
import com.facebook.datasource.BaseDataSubscriber
import com.facebook.datasource.DataSource
import com.facebook.datasource.DataSubscriber
import com.facebook.drawee.backends.pipeline.Fresco
import com.facebook.fbreact.specs.NativeImageLoaderAndroidSpec
import com.facebook.imagepipeline.common.RotationOptions
import com.facebook.imagepipeline.core.ImagePipeline
import com.facebook.imagepipeline.image.CloseableImage
import com.facebook.imagepipeline.image.EncodedImage
import com.facebook.imagepipeline.request.ImageRequest
import com.facebook.imagepipeline.request.ImageRequestBuilder
import com.facebook.react.bridge.GuardedAsyncTask
Expand Down Expand Up @@ -82,39 +85,13 @@ internal class ImageLoaderModule : NativeImageLoaderAndroidSpec, LifecycleEventL
return
}
val source = ImageSource(reactApplicationContext, uriString)
val request: ImageRequest = ImageRequestBuilder.newBuilderWithSource(source.uri).build()
val dataSource: DataSource<CloseableReference<CloseableImage>> =
this.imagePipeline.fetchDecodedImage(request, this.callerContext)
val dataSubscriber: DataSubscriber<CloseableReference<CloseableImage>> =
object : BaseDataSubscriber<CloseableReference<CloseableImage>>() {
override fun onNewResultImpl(dataSource: DataSource<CloseableReference<CloseableImage>>) {
if (!dataSource.isFinished) {
return
}
val ref = dataSource.result
if (ref != null) {
try {
val image: CloseableImage = ref.get()
val sizes = buildReadableMap {
put("width", image.width)
put("height", image.height)
}
promise.resolve(sizes)
} catch (e: Exception) {
promise.reject(ERROR_GET_SIZE_FAILURE, e)
} finally {
CloseableReference.closeSafely(ref)
}
} else {
promise.reject(ERROR_GET_SIZE_FAILURE, "Failed to get the size of the image")
}
}

override fun onFailureImpl(dataSource: DataSource<CloseableReference<CloseableImage>>) {
promise.reject(ERROR_GET_SIZE_FAILURE, dataSource.failureCause)
}
}
dataSource.subscribe(dataSubscriber, CallerThreadExecutor.getInstance())
val request: ImageRequest =
ImageRequestBuilder.newBuilderWithSource(source.uri)
.setRotationOptions(RotationOptions.disableRotation())
.build()
val dataSource: DataSource<CloseableReference<PooledByteBuffer>> =
this.imagePipeline.fetchEncodedImage(request, this.callerContext)
dataSource.subscribe(createSizeSubscriber(promise), CallerThreadExecutor.getInstance())
}

/**
Expand All @@ -134,41 +111,61 @@ internal class ImageLoaderModule : NativeImageLoaderAndroidSpec, LifecycleEventL
val source = ImageSource(reactApplicationContext, uriString)
val imageRequestBuilder: ImageRequestBuilder =
ImageRequestBuilder.newBuilderWithSource(source.uri)
Comment thread
zoontek marked this conversation as resolved.
.setRotationOptions(RotationOptions.disableRotation())
val request: ImageRequest =
ReactNetworkImageRequest.fromBuilderWithHeaders(imageRequestBuilder, headers)
val dataSource: DataSource<CloseableReference<CloseableImage>> =
this.imagePipeline.fetchDecodedImage(request, this.callerContext)
val dataSubscriber: DataSubscriber<CloseableReference<CloseableImage>> =
object : BaseDataSubscriber<CloseableReference<CloseableImage>>() {
override fun onNewResultImpl(dataSource: DataSource<CloseableReference<CloseableImage>>) {
if (!dataSource.isFinished) {
return
}
val ref = dataSource.result
if (ref != null) {
try {
val image: CloseableImage = ref.get()
val sizes = buildReadableMap {
put("width", image.width)
put("height", image.height)
}
promise.resolve(sizes)
} catch (e: Exception) {
promise.reject(ERROR_GET_SIZE_FAILURE, e)
} finally {
CloseableReference.closeSafely(ref)
val dataSource: DataSource<CloseableReference<PooledByteBuffer>> =
this.imagePipeline.fetchEncodedImage(request, this.callerContext)
dataSource.subscribe(createSizeSubscriber(promise), CallerThreadExecutor.getInstance())
}

private fun createSizeSubscriber(
promise: Promise
): DataSubscriber<CloseableReference<PooledByteBuffer>> =
object : BaseDataSubscriber<CloseableReference<PooledByteBuffer>>() {
override fun onNewResultImpl(dataSource: DataSource<CloseableReference<PooledByteBuffer>>) {
if (!dataSource.isFinished) {
return
}
val ref = dataSource.result
if (ref != null) {
var encodedImage: EncodedImage? = null
try {
encodedImage = EncodedImage(ref)
// Swap width and height when the image's EXIF orientation swaps the X/Y axes
// (90°/270° rotations, or transpose/transverse), so the values reflect the
// visible dimensions, matching iOS behavior.
val rotated =
encodedImage.rotationAngle == 90 ||
encodedImage.rotationAngle == 270 ||
encodedImage.exifOrientation == ExifInterface.ORIENTATION_TRANSPOSE ||
encodedImage.exifOrientation == ExifInterface.ORIENTATION_TRANSVERSE
val width = if (rotated) encodedImage.height else encodedImage.width
val height = if (rotated) encodedImage.width else encodedImage.height
if (width < 0 || height < 0) {
promise.reject(ERROR_GET_SIZE_FAILURE, "Failed to get the size of the image")
return
}
val sizes = buildReadableMap {
put("width", width)
put("height", height)
}
} else {
promise.reject(ERROR_GET_SIZE_FAILURE, "Failed to get the size of the image")
promise.resolve(sizes)
} catch (e: Exception) {
promise.reject(ERROR_GET_SIZE_FAILURE, e)
} finally {
encodedImage?.close()
CloseableReference.closeSafely(ref)
}
} else {
promise.reject(ERROR_GET_SIZE_FAILURE, "Failed to get the size of the image")
}
}

override fun onFailureImpl(dataSource: DataSource<CloseableReference<CloseableImage>>) {
promise.reject(ERROR_GET_SIZE_FAILURE, dataSource.failureCause)
}
override fun onFailureImpl(dataSource: DataSource<CloseableReference<PooledByteBuffer>>) {
promise.reject(ERROR_GET_SIZE_FAILURE, dataSource.failureCause)
}
dataSource.subscribe(dataSubscriber, CallerThreadExecutor.getInstance())
}
}

/**
* Prefetches the given image to the Fresco image disk cache.
Expand Down
Loading