Close connection with CONNECTION_ID_LIMIT_ERROR when peer exceeds act…#460
Open
UditDewan wants to merge 1 commit into
Open
Close connection with CONNECTION_ID_LIMIT_ERROR when peer exceeds act…#460UditDewan wants to merge 1 commit into
UditDewan wants to merge 1 commit into
Conversation
…ive_connection_id_limit Per RFC 9000 Section 5.1.1, after processing a NEW_CONNECTION_ID frame, if the number of active connection IDs exceeds the advertised active_connection_id_limit, an endpoint MUST close the connection with an error of type CONNECTION_ID_LIMIT_ERROR. mvfst previously ignored such frames silently, based on behavior that was unspecified as of draft-23. - Add the missing CONNECTION_ID_LIMIT_ERROR (0x09) code from RFC 9000 to TransportErrorCode, with toString support. - Return a connection error from updateSimpleFrameOnPacketReceived instead of dropping the frame when the limit is exceeded. - Update client and server transport tests to expect the connection close. Fixes facebook#320
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ive_connection_id_limit
Per RFC 9000 Section 5.1.1, after processing a NEW_CONNECTION_ID frame, if the number of active connection IDs exceeds the advertised active_connection_id_limit, an endpoint MUST close the connection with an error of type CONNECTION_ID_LIMIT_ERROR. mvfst previously ignored such frames silently, based on behavior that was unspecified as of draft-23.
Fixes #320