Avoid redundant allocations#620
Conversation
* Most of the PsiElements are composites with an expensive text query, and they are skipped anyway * Use token type instead of text matching where appropriate * Use PsiElement.textContains(char) where appropriate * No semantic changes, total performance improvement is around ~6%
|
Hi @qwwdfsad! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@AbdullinAM PTAL |
meta-cla
Bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Could you update the |
|
Sure, done |
|
@hick209 has imported this pull request. If you are a Meta employee, you can view this in D107013190. |
AbdullinAM
left a comment
AbdullinAM
left a comment
There was a problem hiding this comment.
Nice work! Note for the future: we should add some benchmarks in this repo, to track these kind of performance gains
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
4 participants
PsiElement: no directtextaccess where appropriate as it's relatively expensivekotlinx.coroutinesruns (5 -> 4.65 sec in sequantial mode)Partially addresses #619