Skip to content

fix: resolve #463 — Tests fail without any message if there are type errors#704

Open
ed-thuando wants to merge 1 commit into
facebook:mainfrom
ed-thuando:contribai/improve/quality/add-error-handling-for-typescript-module
Open

fix: resolve #463 — Tests fail without any message if there are type errors#704
ed-thuando wants to merge 1 commit into
facebook:mainfrom
ed-thuando:contribai/improve/quality/add-error-handling-for-typescript-module

Conversation

@ed-thuando

Copy link
Copy Markdown

Summary

fix: resolve #463 — Tests fail without any message if there are type errors

Problem

Severity: Medium | File: utils/testUtils.js

The issue is that when testing TypeScript transforms with type errors, the tests fail silently without any error message. The runTest function imports the transform module using require(), but if there are TypeScript compilation errors (type errors), the require fails without providing any useful error message to the user. This makes debugging TypeScript issues very difficult.

Solution

Modify the runTest function in utils/testUtils.js to wrap the require(path.join(dirName, '..', transformName)) call in a try-catch block. When an error is caught, log the error message with console.log('Error importing module', e) before allowing the test to proceed. This will ensure that even if the module has TypeScript type errors, the error will be visible to the user instead of the test just failing silently.

Changes

  • utils/testUtils.js (modified)

Testing

  • Existing tests pass
  • Manual review completed
  • No new warnings/errors introduced

Generated by ContribAI v6.0.0

…re type errors

Fixes facebook#463

Signed-off-by: ed-thuando <231172918+ed-thuando@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Apr 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d79c67b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Apr 11, 2026

Copy link
Copy Markdown

@ed-thuando is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla

meta-cla Bot commented Apr 11, 2026

Copy link
Copy Markdown

Hi @ed-thuando!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Daniel15

Copy link
Copy Markdown
Member

How does this fix the issue? The runTest function isn't called from anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail without any message if there are type errors

2 participants