Remove mcrouter autotools build and update docs#9806
Open
mszabo-wikia wants to merge 1 commit into
Open
Conversation
mcrouter has had a working CMake build system usable via `getdeps` since D91269570. Remove the old autotools build system and outdated build / installation scripts accordingly, and update the README to provide a brief primer on building mcrouter using `getdeps`. Note: `build/fbcode_builder` currently doesn't seem to be automatically mirrored to the mcrouter GitHub repo, unlike other repositories like facebook/mvfst. This isn't the end of the world since consumers can obtain it from e.g. folly and copy it to the right place, but it's slightly confusing.
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D109097494. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mcrouter has had a working CMake build system usable via
getdepssince D91269570. Remove the old autotools build system and outdated build / installation scripts accordingly, and update the README to provide a brief primer on building mcrouter usinggetdeps.Note:
build/fbcode_buildercurrently doesn't seem to be automatically mirrored to the mcrouter GitHub repo, unlike other repositories like facebook/mvfst. This isn't the end of the world since consumers can obtain it from e.g. folly and copy it to the right place, but it's slightly confusing.