Skip to content

[Celestica] Icecube: Config: Migrate icecube fan CPLD to fbfancpld and inline hardware configs - #1433

Open
zhongedward wants to merge 1 commit into
facebook:mainfrom
zhongedward:add_fbfancpld_driver_for_icecube
Open

[Celestica] Icecube: Config: Migrate icecube fan CPLD to fbfancpld and inline hardware configs#1433
zhongedward wants to merge 1 commit into
facebook:mainfrom
zhongedward:add_fbfancpld_driver_for_icecube

Conversation

@zhongedward

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
icecube

Summary

Migrate the icecube fan CPLD kernel device definition from the legacy icecube_fancpld down to the unified upstream standard fbfancpld driver.

Mainly change as follows:

  • Set active fan count payload (numFans: 4).
  • Set the absolute raw hardware register limitation (pwmMax: 64).
  • Align the tachometer pulse factor mapping via speedMultiplier: 300.
  • Enable dual-rotor status tracking via hasRearTach: true.

Test Plan

  1. Syntax Validation: Validated JSON syntax using JSONLint.
  2. Formatting: Pretty-printed configurations using the jq command for readability.
  3. Build & Config Tests: Compilation and configuration validation tests passed successfully.
  4. Service Verification: Confirmed that the following services start and run without errors:
    • platform_manager/platform_hw_test/platform_manager_hw_test
    • sensor_service/sensor_service_client/sensor_service_sw_test/sensor_service_hw_test

Attachments:
icecube_2026_07_14_test_log.zip

@meta-cla meta-cla Bot added the CLA Signed label Jul 29, 2026
@zhongedward
zhongedward marked this pull request as ready for review July 29, 2026 03:15
@zhongedward
zhongedward requested a review from a team as a code owner July 29, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant