Skip to content

[Celestica] Icecube: Config: Abstract CPU I2C bus name to CPU_BUS@0 in platform_manager - #1429

Open
zhongedward wants to merge 1 commit into
facebook:mainfrom
zhongedward:update_i2c_adapters_name_from_cpu
Open

[Celestica] Icecube: Config: Abstract CPU I2C bus name to CPU_BUS@0 in platform_manager#1429
zhongedward wants to merge 1 commit into
facebook:mainfrom
zhongedward:update_i2c_adapters_name_from_cpu

Conversation

@zhongedward

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
icecube

Summary

Abstract the legacy CPU I2C adapter bus definition in icecube's platform_manager.json to align with the unified CPU bus naming convention.

Mainly change as follows:

  • Abstract the hardcoded I2C bus name SMBus I801 adapter at 5000 to the standardized virtual bus CPU_BUS@0.
  • Update the idpromConfig entry under MCB_SLOT to use CPU_BUS@0.
  • Align i2cAdaptersFromCpu declaration list with CPU_BUS@0.

Test Plan

  1. Syntax Validation: Validated JSON syntax using JSONLint.
  2. Formatting: Pretty-printed configurations using the jq command for readability.
  3. Build & Config Tests: Compilation and configuration validation tests passed successfully.
  4. Dual-Kernel Service Verification: Confirmed backward/forward kernel compatibility by verifying that the full platform test suite runs without errors across both Kernel 6.11.1 and Kernel 6.16.1 target hardware environments:
    • platform_manager/platform_hw_test/platform_manager_hw_test
    • sensor_service/sensor_service_client/sensor_service_sw_test/sensor_service_hw_test

Attachments:

icecube_test_log_2026_7_27.zip

@meta-cla meta-cla Bot added the CLA Signed label Jul 28, 2026
@zhongedward
zhongedward marked this pull request as ready for review July 28, 2026 09:24
@zhongedward
zhongedward requested a review from a team as a code owner July 28, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant