[Nexthop][platform_manager][m4062nhp] Record sysfs path for miscCtrlConfigs entries - #1417
Open
anna-nexthop wants to merge 1 commit into
Open
Conversation
…ries Makes `PciExplorer::createFpgaIpBlock()` return the created auxiliary device's sysfs path, and has `PlatformExplorer` record that path in the DataStore for `miscCtrlConfigs` entries (as already done for other FPGA IP blocks). Without it, downstream services (e.g. `sensor_service`) can't locate a misc-control FPGA IP block's sysfs node, so registers exposed via `miscCtrlConfigs`, such as an ASIC temperature register, can't be read.
anna-nexthop
changed the title
anna-nexthop
marked this pull request as ready for review
July 24, 2026 22:53
srikrishnagopu
self-requested a review
July 25, 2026 04:57
Contributor
|
@srikrishnagopu has imported this pull request. If you are a Meta employee, you can view this in D113635085. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Makes
PciExplorer::createFpgaIpBlock()return the created auxiliary device's sysfs path, and hasPlatformExplorerrecord that path in the DataStore formiscCtrlConfigsentries (as already done for other FPGA IP blocks). Without it, downstream services (e.g.sensor_service) can't locate a misc-control FPGA IP block's sysfs node, so registers exposed viamiscCtrlConfigs, such as an ASIC temperature register, can't be read.Test Plan
Built and verified against hardware.