[Nexthop][distro] Raise root's nofile ulimit for hw tests - #1402
Open
zackary-nexthop wants to merge 1 commit into
Open
[Nexthop][distro] Raise root's nofile ulimit for hw tests#1402zackary-nexthop wants to merge 1 commit into
zackary-nexthop wants to merge 1 commit into
Conversation
zackary-nexthop
force-pushed
the
zackary-nexthop.distro.m4062nhp.fd-exhaustion
branch
from
July 22, 2026 14:20
fb0b34f to
a562278
Compare
Contributor
|
Please remove the m4062 tag since this is related to Distor. @kevin645 please review. |
Contributor
|
@kevin645 has imported this pull request. If you are a Meta employee, you can view this in D113475164. |
zackary-nexthop
force-pushed
the
zackary-nexthop.distro.m4062nhp.fd-exhaustion
branch
from
July 24, 2026 12:55
a562278 to
caf1b44
Compare
|
@zackary-nexthop has updated the pull request. You must reimport the pull request before landing. |
**Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` `qsfp_hw_test` opens one thread per transceiver slot. On m4062nhp (129 transceiver slots) this exceeds the default `ulimit -n` of 1024, so every test case fails in `SetUp()` with "Too many open files". Lower-port platforms never hit this ceiling. Raises root's nofile default to 65536 via a limits.d entry in the image template. No new capability granted: the hard limit was already 524288 system-wide. Applied the same `limits.conf` change on a live m4062nhp DUT and confirmed `ulimit -n` reads 65536 and the previously-failing qsfp hw tests now pass.
zackary-nexthop
force-pushed
the
zackary-nexthop.distro.m4062nhp.fd-exhaustion
branch
from
July 24, 2026 12:56
caf1b44 to
ec818fa
Compare
|
@zackary-nexthop has updated the pull request. You must reimport the pull request before landing. |
zackary-nexthop
changed the title
Contributor
Author
@kevin645 @srikrishnagopu I hadn't noticed that this had been imported already. Had to rebase so workflows pass, hope that's ok! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
qsfp_hw_testopens one thread per transceiver slot. On m4062nhp (129 transceiver slots) this exceeds the defaultulimit -nof 1024, so every test case fails inSetUp()with "Too many open files". Lower-port platforms never hit this ceiling.Raises root's nofile default to 65536 via a limits.d entry in the image template. No new capability granted: the hard limit was already 524288 system-wide.
Test Plan
Applied the same
limits.confchange on a live m4062nhp DUT and confirmedulimit -nreads 65536 and the previously-failing qsfp hw tests now pass.