Skip to content

[Nexthop][fboss2-dev] fboss2 config/delete protocol bgp policy as-path-list commands #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hillol-nexthop wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[Nexthop][fboss2-dev] fboss2 config/delete protocol bgp policy as-path-list commands #1401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
06d0b15
BGP-aware fboss2 config session (ConfigSession infra)
hillol-nexthop Jun 25, 2026
e57671a
Use the bgpd systemd unit name instead of bgp_pp
hillol-nexthop Jul 16, 2026
cbe6287
[Nexthop][fboss2-dev] symlink /etc/coop/bgpcpp.conf into the CLI-mana…
hillol-nexthop Jul 17, 2026
cb4ecd7
fboss2 bgp config session: address clang-tidy findings
hillol-nexthop Jul 21, 2026
179d659
fboss2 `config protocol bgp global` command
hillol-nexthop Jun 29, 2026
6ff2ba5
bgp global command fixes
hillol-nexthop Jul 16, 2026
e9b8e2b
Verify committed global config via bgpd getRunningConfig RPC
hillol-nexthop Jul 17, 2026
7dd1010
fboss2 `config protocol bgp neighbor` and `delete protocol bgp neighb…
hillol-nexthop Jul 17, 2026
e7d07de
fboss2 bgp config: address clang-tidy findings
hillol-nexthop Jul 21, 2026
a6b9848
fboss2 config/delete protocol bgp peer-group commands
hillol-nexthop Jul 17, 2026
4f223c9
fboss2 bgp config: address clang-tidy findings
hillol-nexthop Jul 21, 2026
bc3ee4b
fboss2 config/delete protocol bgp policy as-path-list commands
hillol-nexthop Jul 21, 2026
c5420a1
fboss2 bgp config: address clang-tidy findings
hillol-nexthop Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 42 additions & 108 deletions cmake/CliFboss2.cmake
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions cmake/CliFboss2TestConfig.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ add_executable(fboss2_cmd_config_test
fboss/cli/fboss2/test/config/CmdConfigAdminDistanceTest.cpp
fboss/cli/fboss2/test/config/CmdConfigAppliedInfoTest.cpp
fboss/cli/fboss2/test/config/CmdConfigArpTest.cpp
fboss/cli/fboss2/test/config/CmdConfigBgpNeighborTest.cpp
fboss/cli/fboss2/test/config/CmdConfigBgpPeerGroupTest.cpp
fboss/cli/fboss2/test/config/CmdConfigIcmpV4UnavailableSrcAddrTest.cpp
fboss/cli/fboss2/test/config/CmdConfigCoppTest.cpp
fboss/cli/fboss2/test/config/CmdConfigDhcpTest.cpp
Expand All @@ -32,6 +34,8 @@ add_executable(fboss2_cmd_config_test
fboss/cli/fboss2/test/config/CmdConfigVlanManagerTest.cpp
fboss/cli/fboss2/test/config/CmdConfigVlanPortTaggingModeTest.cpp
fboss/cli/fboss2/test/config/CmdConfigVlanStaticMacTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteBgpNeighborTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteBgpPeerGroupTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteConfigInterfaceTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteInterfaceIpv6NdpTest.cpp
fboss/cli/fboss2/test/config/CmdDeleteInterfaceTest.cpp
Expand Down
4 changes: 4 additions & 0 deletions cmake/CliFboss2TestIntegrationTest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ add_executable(fboss2_integration_test
fboss/cli/fboss2/test/integration_test/Fboss2IntegrationTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigAdminDistanceTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigArpTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpGlobalTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpNeighborTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpPeerGroupTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigBgpSessionTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigConcurrentSessionsTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigHostnameTest.cpp
fboss/cli/fboss2/test/integration_test/ConfigIcmpV4UnavailableSrcAddrTest.cpp
Expand Down
111 changes: 20 additions & 91 deletions fboss/cli/fboss2/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,61 +1069,10 @@ cpp_library(
"commands/config/protocol/bgp/BgpConfigSession.cpp",
"commands/config/protocol/bgp/CmdConfigProtocolBgp.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobal.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalClusterId.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalConfedAsn.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalHoldTime.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalLocalAsn.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalNetwork6Add.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalRouterId.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalSwitchLimitMaxGoldenVips.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalSwitchLimitOverloadProtectionMode.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalSwitchLimitPrefixLimit.cpp",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalSwitchLimitTotalPathLimit.cpp",
"commands/config/protocol/bgp/neighbor/CmdConfigProtocolBgpNeighbor.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroup.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupConfedPeer.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupDescription.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupDisableIpv4Afi.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupEgressPolicy.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupIngressPolicy.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupMaxRoutes.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupNextHopSelf.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupPeerTag.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupRemoteAsn.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupRrClient.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimers.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersHoldTime.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersKeepalive.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersOutDelay.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersWithdrawUnprogDelay.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupV4OverV6Nh.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupWarningLimit.cpp",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupWarningOnly.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeer.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerAdvertiseLbw.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerDescription.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerDisableIpv4Afi.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerEgressPolicy.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerHoldTime.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerIngressPolicy.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerLinkBandwidth.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerLocalAddr.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerMaxRoutes.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHop4.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHop6.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHopSelf.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerPassive.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerPeerGroup.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerPeerId.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerRemoteAsn.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerRrClient.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerTimers.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerTimersKeepalive.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerTimersOutDelay.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerTimersWithdrawUnprogDelay.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerType.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerV4OverV6Nh.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerWarningLimit.cpp",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerWarningOnly.cpp",
"commands/config/protocol/bgp/policy/CmdConfigProtocolBgpPolicy.cpp",
"commands/config/protocol/bgp/policy/as-path-list/CmdConfigProtocolBgpPolicyAsPathList.cpp",
"commands/config/protocol/static/CmdConfigProtocolStatic.cpp",
"commands/config/protocol/static/route/add/CmdConfigProtocolStaticRouteAdd.cpp",
"commands/config/ptp/CmdConfigPtp.cpp",
Expand Down Expand Up @@ -1162,6 +1111,11 @@ cpp_library(
"commands/delete/interface/ipv6/CmdDeleteInterfaceIpv6.cpp",
"commands/delete/interface/ipv6/ndp/CmdDeleteInterfaceIpv6Ndp.cpp",
"commands/delete/protocol/CmdDeleteProtocol.cpp",
"commands/delete/protocol/bgp/CmdDeleteProtocolBgp.cpp",
"commands/delete/protocol/bgp/neighbor/CmdDeleteProtocolBgpNeighbor.cpp",
"commands/delete/protocol/bgp/peer-group/CmdDeleteProtocolBgpPeerGroup.cpp",
"commands/delete/protocol/bgp/policy/CmdDeleteProtocolBgpPolicy.cpp",
"commands/delete/protocol/bgp/policy/as-path-list/CmdDeleteProtocolBgpPolicyAsPathList.cpp",
"commands/delete/protocol/static/CmdDeleteProtocolStatic.cpp",
"commands/delete/protocol/static/route/CmdDeleteProtocolStaticRoute.cpp",
"commands/delete/tunnel/CmdDeleteTunnel.cpp",
Expand Down Expand Up @@ -1205,47 +1159,16 @@ cpp_library(
"commands/config/mac/CmdConfigMac.h",
"commands/config/mac/aging_time/CmdConfigMacAgingTime.h",
"commands/config/protocol/CmdConfigProtocol.h",
"commands/config/protocol/bgp/BgpCliValueParsers.h",
"commands/config/protocol/bgp/BgpPeerAddr.h",
"commands/config/protocol/bgp/BgpConfigSession.h",
"commands/config/protocol/bgp/CmdConfigProtocolBgp.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobal.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalClusterId.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalConfedAsn.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalHoldTime.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalLocalAsn.h",
"commands/config/protocol/bgp/global/CmdConfigProtocolBgpGlobalRouterId.h",
"commands/config/protocol/bgp/neighbor/CmdConfigProtocolBgpNeighbor.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroup.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupConfedPeer.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupDescription.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupDisableIpv4Afi.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupEgressPolicy.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupIngressPolicy.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupMaxRoutes.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupNextHopSelf.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupRemoteAsn.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupRrClient.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimers.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersHoldTime.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersKeepalive.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupTimersOutDelay.h",
"commands/config/protocol/bgp/peer-group/CmdConfigProtocolBgpPeerGroupV4OverV6Nh.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeer.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerAdvertiseLbw.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerDescription.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerDisableIpv4Afi.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerEgressPolicy.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerHoldTime.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerIngressPolicy.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerLinkBandwidth.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerLocalAddr.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerMaxRoutes.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHop4.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHop6.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerNextHopSelf.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerPassive.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerPeerGroup.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerRemoteAsn.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerRrClient.h",
"commands/config/protocol/bgp/peer/CmdConfigProtocolBgpPeerV4OverV6Nh.h",
"commands/config/protocol/bgp/BgpCliAttrHandlers.h",
"commands/config/protocol/bgp/policy/CmdConfigProtocolBgpPolicy.h",
"commands/config/protocol/bgp/policy/as-path-list/CmdConfigProtocolBgpPolicyAsPathList.h",
"commands/config/protocol/static/CmdConfigProtocolStatic.h",
"commands/config/protocol/static/route/StaticRouteUtils.h",
"commands/config/protocol/static/route/add/CmdConfigProtocolStaticRouteAdd.h",
Expand Down Expand Up @@ -1285,6 +1208,11 @@ cpp_library(
"commands/delete/interface/ipv6/CmdDeleteInterfaceIpv6.h",
"commands/delete/interface/ipv6/ndp/CmdDeleteInterfaceIpv6Ndp.h",
"commands/delete/protocol/CmdDeleteProtocol.h",
"commands/delete/protocol/bgp/CmdDeleteProtocolBgp.h",
"commands/delete/protocol/bgp/neighbor/CmdDeleteProtocolBgpNeighbor.h",
"commands/delete/protocol/bgp/peer-group/CmdDeleteProtocolBgpPeerGroup.h",
"commands/delete/protocol/bgp/policy/CmdDeleteProtocolBgpPolicy.h",
"commands/delete/protocol/bgp/policy/as-path-list/CmdDeleteProtocolBgpPolicyAsPathList.h",
"commands/delete/protocol/static/CmdDeleteProtocolStatic.h",
"commands/delete/protocol/static/route/CmdDeleteProtocolStaticRoute.h",
"commands/delete/tunnel/CmdDeleteTunnel.h",
Expand Down Expand Up @@ -1329,6 +1257,7 @@ cpp_library(
":cmd-handler",
":fboss2-lib",
"//common/network/if:if-cpp2-types",
"//configerator/structs/neteng/fboss/bgp:bgp_config-cpp2-types",
"//fboss/agent:agent_config-cpp2-types",
"//fboss/agent:fboss-types",
"//fboss/agent:platform_config-cpp2-types",
Expand Down
Loading
Loading