Fix let_underscore_drop lint error in dice_tracker - #1406
Conversation
|
This pull request has been imported. If you are a Meta employee, you can view this in D113539998. (Because this pull request was imported automatically, there will not be any future comments.) |
The new HydrationFailed variant added a String field to DiceEvent, giving it a destructor. That arms the deny-listed let_underscore_drop lint on the pre-existing `let _ =` in BuckDiceTracker::event, and the accompanying paging test added another violation, breaking `cargo clippy` in OSS CI for every PR. Bind to `_ignored` like other call sites that discard such results. Signed-off-by: Daan De Meyer <daan@amutable.com>
529a277 to
22844ba
Compare
ndmitchell
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
The macos failure here is an unrelated timing flake: |
|
This pull request has been merged in 3c9f680. |
|
Thanks! |
OSS CI (
test.py/cargo clippy) is currently failing on every PR and on main itself with:0578509 added the
HydrationFailedvariant with aStringfield toDiceEvent, giving it a destructor. That armed the deny-listedlet_underscore_droplint (lint_levels.bzl) on the pre-existinglet _ =inBuckDiceTracker::event. Bind to_ignoredinstead, matching other call sites that discardunbounded_sendresults.🤖 Generated with Claude Code