fs_util: recover from permission errors when removing buck-out paths#1352
Open
daandemeyer wants to merge 1 commit into
Open
fs_util: recover from permission errors when removing buck-out paths#1352daandemeyer wants to merge 1 commit into
daandemeyer wants to merge 1 commit into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D110600034. (Because this pull request was imported automatically, there will not be any future comments.) |
daandemeyer
force-pushed
the
push-swmprlnklvnu
branch
from
July 3, 2026 14:02
d633117 to
0840055
Compare
When building OS images with buck2, read-only directories show up in buck-out because various distributions give their top level directories and directories in /etc restrictive permissions. Removing such outputs fails with EACCES, since unlinking a directory entry requires write and execute permission on the containing directory. Mirror the existing Windows readonly fallback on Unix: - remove_dir_all() now adds owner read/write/execute permission on every directory in the tree and retries when it hits a permission error. It only ever modifies directories inside the tree being removed; in particular it never touches the parent directory of the path passed in. - A new remove_file_harder() adds owner read/write/execute permission on the containing directory and retries. Since that side effects the permissions of the (surviving) parent directory, it is kept separate from remove_file() and only used where the surrounding tree is being deleted anyway: the parallel file removal pass of buck2 clean and cleanup_path().
daandemeyer
force-pushed
the
push-swmprlnklvnu
branch
from
July 6, 2026 10:16
0840055 to
166a97a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building OS images with buck2, read-only directories show up in
buck-out because various distributions give their top level directories
and directories in /etc restrictive permissions. Removing such outputs
fails with EACCES, since unlinking a directory entry requires write and
execute permission on the containing directory.
Mirror the existing Windows readonly fallback on Unix:
remove_dir_all() now adds owner read/write/execute permission on
every directory in the tree and retries when it hits a permission
error. It only ever modifies directories inside the tree being
removed; in particular it never touches the parent directory of the
path passed in.
A new remove_file_harder() adds owner read/write/execute permission
on the containing directory and retries. Since that side effects the
permissions of the (surviving) parent directory, it is kept separate
from remove_file() and only used where the surrounding tree is being
deleted anyway: the parallel file removal pass of buck2 clean and
cleanup_path().