Skip to content

docs(core): replace ellipsis char in DateRangeInput prop prose - #4841

Merged
cixzhang merged 1 commit into
mainfrom
navi/docs/slop-35
Aug 12, 2026
Merged

docs(core): replace ellipsis char in DateRangeInput prop prose#4841
cixzhang merged 1 commit into
mainfrom
navi/docs/slop-35

Conversation

@josephfarina

Copy link
Copy Markdown
Contributor

What

The weekStartsOn description in DateRangeInput.doc.mjs used a Unicode ellipsis (U+2026) inside prose: 0 = Sunday ... 6 = Saturday. The ellipsis stood for a numeric range, so replace it with to, matching the same fix already applied to DateInput and DateTimeInput.

Prose only; no meaning changed.

Validation

  • pnpm --filter @astryxdesign/core typecheck:docs passes
  • astryx component DateRangeInput --lang dense renders cleanly

Night Watch — Doc Reviewer

The weekStartsOn description used a Unicode ellipsis (U+2026) inside
prose: '0 = Sunday ... 6 = Saturday'. The ellipsis stood for a range,
so replace it with 'to' as in DateInput and DateTimeInput. Prose only;
no meaning changed.

Found during Night Watch doc review.
@vercel

vercel Bot commented Aug 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
astryx Ignored Ignored Aug 9, 2026 9:21am

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

Modified Components

DateRangeInput (@astryxdesign/core) · View in Storybook
Metric Before After Delta
Bundle Size (ESM) N/A N/A N/A
Lines of Code N/A 495 -
Complexity N/A Very High (59) -

Bundle Size Summary

Package Size (ESM) Size (CJS) Gzipped
@astryxdesign/core N/A 4.7KB 1.2KB

Accessibility Audit

Status: 1 accessibility violation(s) found — 1 critical.

DateRangeInput - 1 issue(s)
  • 🔴 critical: Ensure an element's role supports its ARIA attributes
    • Rule: aria-allowed-attr · Affects 1/18 stories · Learn more
    • WCAG: 4.1.2 (Level A)

Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

github-actions Bot added a commit that referenced this pull request Aug 9, 2026

@cixzhang cixzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — docs-only, no behavior change, CI green.

@cixzhang
cixzhang merged commit 8360f05 into main Aug 12, 2026
18 checks passed
@github-actions
github-actions Bot deleted the navi/docs/slop-35 branch August 13, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants