fix: don't ship source files in binding packages - #16
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CreateFablePackageFilesincludes the project's@(Compile)files (and the.fsproj) under thefable/folder of the produced NuGet package. Its comment says this is "if FablePackageType is a library", but the target had noCondition, so it ran forbindingpackages too.As a result, a pure-interop binding shipped its full F# source in
fable/. Fable prefers that source over the compiled DLL, so every consumer recompiles the whole binding from source on each build. For a large binding this is very expensive (e.g. a ~194k-line binding is ~27s of Fable transform per consumer build, vs ~0.6s when consumed as a plain DLL).Fix
Add the missing condition so the source is only packaged for
librarypackages:A
bindingpackage now ships only itslib/*.dll, and Fable consumes it from the assembly (interfaces +[<Import>]/[<Emit>]/[<Erase>]metadata) without recompiling it.Test
Added
should not include any source file for a binding package: it packs a newbinding-with-filesfixture and asserts the nupkg contains nofable/entries. The existing library tests still assert thatlibrarypackages do ship their source, so both directions are covered. Full suite: 23/23 passing.🤖 Generated with Claude Code
https://claude.ai/code/session_011rgT2YXmo7LaUFmMFNpx9k