Skip to content

fix: update terminology from "series number" to "number in series" #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Himura2la wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix: update terminology from "series number" to "number in series" #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,7 +901,7 @@ Pinakes v0.7.x introduced a full library-interoperability layer, delivered as op

- Collane now support an optional umbrella group for related spin-offs, universes, or franchises, so separate series like `Fairy Tail`, `Fairy Tail: 100 Year Quest`, and `Fairy Tail: Happy` can remain distinct while sharing one parent group.
- Collane also support an optional cycle/season label plus numeric ordering, matching LibraryThing-style series such as `The Worlds of Aldebaran` with `Cycle 1`, `Cycle 2`, and later arcs.
- Book create/edit forms can set group, cycle/season, cycle order, series name, and series number in one flow; the Collane admin page exposes the same metadata and shows related series in the same group.
- Book create/edit forms can set group, cycle/season, cycle order, series name, and number in series in one flow; the Collane admin page exposes the same metadata and shows related series in the same group.

### Archives plugin (ISAD(G) / ISAAR(CPF))

Expand Down
2 changes: 1 addition & 1 deletion app/Controllers/CsvImportController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,7 @@ private function mapColumnHeaders(array $headers): array
'prezzo' => ['prezzo', 'price', 'precio', 'prix', 'preis', 'list price', 'purchase price'],
'copie_totali' => ['copie_totali', 'copie', 'copies', 'quantity', 'quantità', 'cantidad'],
'collana' => ['collana', 'series', 'collection', 'collections', 'colección', 'reihe'],
'numero_serie' => ['numero_serie', 'series number', 'número de serie', 'numéro de série'],
'numero_serie' => ['numero_serie', 'number in series', 'número de serie', 'numéro de série'],

@coderabbitai coderabbitai Bot Jul 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Mantieni anche l’alias CSV precedente.

La rimozione di series number rompe i CSV già esportati: l’intestazione non viene mappata a numero_serie, che alla Line 849 risulta quindi assente. Un re-import può così cancellare il valore esistente in libri.numero_serie.

-            'numero_serie' => ['numero_serie', 'number in series', 'número de serie', 'numéro de série'],
+            'numero_serie' => ['numero_serie', 'series number', 'number in series', 'número de serie', 'numéro de série'],
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
'numero_serie' => ['numero_serie', 'number in series', 'número de serie', 'numéro de série'],
'numero_serie' => ['numero_serie', 'series number', 'number in series', 'número de serie', 'numéro de série'],
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/Controllers/CsvImportController.php` at line 1102, Ripristina l’alias CSV
precedente “series number” nell’elenco degli alias associati a `numero_serie` in
`CsvImportController`, mantenendo anche gli alias attuali. Verifica che
l’intestazione venga nuovamente mappata a `numero_serie` durante l’import per
preservare i valori esistenti.

'traduttore' => ['traduttore', 'translator', 'traductor', 'traducteur', 'übersetzer'],
'illustratore' => ['illustratore', 'illustrator', 'ilustrador', 'illustrateur', 'zeichner'],
'parole_chiave' => ['parole_chiave', 'parole chiave', 'keywords', 'tags', 'palabras clave', 'mots-clés', 'schlagwörter', 'subjects'],
Expand Down
4 changes: 2 additions & 2 deletions locale/en_US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3218,7 +3218,7 @@
"Numero Inventario": "Inventory Number",
"Numero Libri": "Number of Books",
"Numero Pagine": "Number of Pages",
"Numero Serie": "Series Number",
"Numero Serie": "Number in Series",
"Numero colonne non valido": "Invalid column count",
"Numero di Pagine": "Number of Pages",
"Numero di copie non valido.": "Invalid number of copies.",
Expand All @@ -3228,7 +3228,7 @@
"Numero massimo di righe superato (%d). Dividi il file in parti più piccole.": "Maximum number of rows exceeded (%d). Split the file into smaller parts.",
"Numero o descrizione dell'edizione": "Edition number or description",
"Numero prenotazioni attive": "Number of active reservations",
"Numero serie": "Series number",
"Numero serie": "Number in series",
"Numero tessera": "Card number",
"Numero volume": "Volume number",
"Nuova Collana": "New Series",
Expand Down
Loading