Remove min-height from book title style - #298
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughNel template del catalogo è stata rimossa la regola CSS mobile che impostava ChangesAltezza titoli catalogo
Estimated code review effort: 1 (Trivial) | ~2 minuti 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks to Custom CSS working on OPAC pages, I was able to test this xD |
|
The alignment problem you're pointing at is real. Digging in, though, this specific change doesn't fix it: with I've opened #302, which keeps the intent — cards that line up — and makes it work: the subtitle stays conditional (no wasted space on the rows without one), and a per-row script equalises title and subtitle heights so any row that has a subtitle lines up across all its cards, while rows without one stay compact. Closing this in favour of #302. |
CodeRabbit: align() grouped every .book-card on the page by vertical position, so if a page renders two .books-grid containers, cards from different grids at the same top could be merged into one logical row and get wrong placeholders / heights. Iterate over each .books-grid and group only its own cards.
…ight CodeRabbit: .book-author has height:1.3em + overflow:hidden but no explicit line-height, so the default (~1.2) could clip the single line top/bottom. Set line-height:1.3 to match the box height (.book-meta already pairs 1.5/1.5em).
CodeRabbit: the spec only exercised a single grid, so a return to global row grouping wouldn't be caught. Add a case that builds two side-by-side grids sharing the same row top, and asserts a subtitle in grid A reserves space only within grid A — grid B (no subtitle) is untouched.
Release candidate bundling the reviewed catalogue + scraper + i18n work: - #303 catalogue availability facets, source-derived language stats, Open Library 1.0.2 native Goodreads cover scraper, #304 email fixes, review fixes. - #298 catalogue card row alignment (+ font-swap/thrashing/mobile review fixes). - UI wording: "series number" → "number in series" (README + en_US); the CSV import header mapping is intentionally left unchanged for back-compatibility. No database migration — availability is derived from circulation state and language stats from the shipped locale files.
Before

After

Summary by CodeRabbit