Repository navigation
Cache Normalization results in Expression Normalizer - #9
Merged
ezkimo merged 1 commit intoOct 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExpressionNormalizer::normalize()runs severalpreg_replacepasses over the expression on every call, beforeExpressionCompilereven consults its own cahces. Since normalization is deterministic, repeated invocations wthe the same raw expression redo identical regex wirk every time.This adds in-memory cache keyed by the raw expression, so each distinct expression is normalized exactly once per process. As a result
ExpressionCompiler::compile()andcompileNodeSet()skip redundant normalization for recurring expressions.Changes
src/Schematron/Compiler/ExpressionNormalizer.phpprotected array $normalizationCache(raw expression ⇒ normalized expression)normalize()return cached results immediately; otherwise it runs the existing normalization passes and stores the resultclearCache(): voidto reset the cachesrc/Schematron/compiler/ExpressionCompiler.phpclearCache()now also clears the normalizer cache, keeping the two caches consistenttests/Compiler/ExpressionNormalizerCacheTest.php(new)ExpressionNormalizerto observe how often the normalization passes run:a = bvaa=b) produce identical normalized output (acceptance criterion)clearCache(), the expression is normalized againNotes