Add optional RelationNature to TeamRelation with override; add tests#39
Merged
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
RelationNatureenum (FRIENDLY,NEUTRAL,HOSTILE) to the modelpackage. Each
TeamRelationconstant carries a built-in default nature which maybe queried with
getDefaultNature().TeamRelation#setNatureOverride(RelationNature)andTeamRelation#getNature()— allows server or provider code to re-categorise arelation at runtime. Passing
nulltosetNatureOverrideclears the overrideand restores the builtin default. Overrides are visible JVM-wide because enum
constants are singletons.
TeamRelationTestcovering default natures and override behaviour.Changed
TeamsAPI.API_VERSIONbumped to2.1.0.Migration
No behavioural changes to existing
TeamRelationhelpers:isFriendly()andisHostile()remain unchanged and existing consumers require no changes. Providersthat wish to reclassify relations (for example treating
TRUCEasNEUTRAL) maycall
setNatureOverride(...)during initialisation.