fix(observability): visible loading message on Logs + Traces tabs (v0.11.2)#17
Merged
Merged
Conversation
….11.2) The Logs Explorer and Traces tab both rendered a bare skeleton div for the first 1–2s while the initial query hit ClickHouse. Visually that's indistinguishable from a no-results state — the tab looks dead until rows arrive. Swap both bare `<div className="…-skeleton" aria-busy="true" />` placeholders for the existing EmptyState component, which centers a title + message and already provides role="status" / aria-live="polite" for screen readers. Copy: - LogsTab → "Loading logs…" / "Fetching log entries from ClickHouse for the selected window." - TracesTab → "Loading traces…" / "Fetching trace spans from ClickHouse for the selected window." MetricsTab uses ChartGridSkeleton (4 chart placeholders) — visually informative, no change needed. Co-Authored-By: arun <arun@infrawatchlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Logs and Traces explorers go silent for the first ~1–2s while the initial ClickHouse query loads. The empty body (a bare skeleton div with
aria-busy) is visually indistinguishable from a no-results state — MGupta noticed the dead-tab feel during a v0.11.1 walkthrough.This PR swaps the bare
<div className="…-skeleton" />placeholders for the existingEmptyStatecomponent on both tabs.EmptyStatecenters a title + message and already providesrole=\"status\"/aria-live=\"polite\"for screen readers, so the loading state now both looks alive and announces itself.Copy
MetricsTab — peeked, deliberately skipped
The Metrics tab uses
ChartGridwithloading={true}, which renders 4 rectangular chart placeholders. That's visually informative — the user can tell at a glance that charts are loading. Leaving it alone keeps this PR minimal; a future follow-up could add a header subtitle if we want consistency across all three tabs.Test plan
/observability/<cluster>/logswith a populated namespace selected — within the first 1–2s, the body should now show "Loading logs…" instead of a blank panel./observability/<cluster>/traces— same; "Loading traces…" while the query is in flight.metrics/components/ux.test.jscontinues to pass (no DOM-shape assertions on the skeleton; logic-level classifiers untouched).aria-live=\"polite\"region.Ships as part of v0.11.2 (submodule bump + GH release follow this PR).