fix(registration): initialize diagnostics vars when optimize_poses=False - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
UnboundLocalErroringet_cleaned_poseswhenreturn_diagnostics=Trueandoptimize_poses=False(the default).Problem
outlier_edges,untestable_edges, andfinal_edge_errorswere only defined inside theif optimize_poses:branch, but referenced unconditionally in the diagnostics dict.Fix
Initialize sensible defaults in the
elsebranch:outlier_edges = set()— no outlier removal performeduntestable_edges— computed from edge_scoresfinal_edge_errors = {}— no post-optimization residuals