fix(bindgen): drop ext-php-rs-clang-sys fork to unblock clang-sys consumers#741
Merged
Conversation
Coverage Report for CI Build 26338262295Coverage decreased (-0.02%) to 66.207%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions3 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
|
Bencher Report| Branch | fix/740-drop-clang-sys-fork |
| Testbed | PHP 8.4.21 (cli) (built: May 15 2026 00:31:53) (NTS) |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
ext-php-rs-bindgen 0.72.1-extphprs.2 now depends on upstream clang-sys instead of the renamed ext-php-rs-clang-sys fork. The fork retained the links = "clang" declaration of upstream clang-sys, which meant projects depending on ext-php-rs could not coexist in the same Cargo graph with any crate that also pulls in clang-sys (bindgen, boring-sys, aws-lc-sys, rdkafka, ...). The preserve_none calling convention is matched numerically inside the bindgen fork, so dropping the clang-sys fork is safe. Fixes #740
ptondereau
force-pushed
the
fix/740-drop-clang-sys-fork
branch
from
8c2f551 to
b69ef1a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump
ext-php-rs-bindgento0.72.1-extphprs.2, which depends on upstreamclang-sysinstead of theext-php-rs-clang-sysfork. The fork retainedlinks = "clang"from upstreamclang-sys, so projects depending onext-php-rscould not coexist in the same Cargo graph with any crate that also pulls inclang-sys(bindgen,boring-sys,aws-lc-sys,rdkafka, and anything else built on top ofbindgen).The
preserve_nonecalling convention is matched numerically in the bindgen fork (cc as u32 == 20), so the fork never references any clang-sys-fork-only symbol, which makes pointing the bindgen fork back at upstreamclang-sys = "1"safe. As a belt-and-suspenders,ext-php-rs-clang-syshas also been republished as1.8.1-extphprs.2with itslinks = "clang"removed, so any consumer that still ends up with it transitively is no longer wedged either.Verified locally:
0.15.13paired withbindgen 0.72in a scratch crate.cargo treeshows only upstreamclang-sys v1.8.1shared betweenbindgenandext-php-rs-bindgen, with noext-php-rs-clang-sysanywhere in the graph.cargo test --libpasses 76/76 andcargo build --example hello_worldsucceeds against PHP 8.5.2-dev.Fixes #740.
Checklist