ci: Add id-token permissions to support WIF - #118
Merged
Conversation
Grant workflow-level `id-token: write` in release.yaml and pull_request.yaml so the jobs calling extenda/actions/* can request an OIDC token from GitHub. The release job already re-declared it alongside `contents: write`; job-level blocks replace rather than merge, so that one stays as-is. The extenda wrappers pick their auth mode from the contents of the service-account-key value -- either a legacy `private_key` JSON key or a `workload_identity_provider` federation config. SECRET_AUTH currently holds a legacy key, so this permission is groundwork only. The migration completes when SECRET_AUTH is swapped to a WIF cred-config on the GCP side, which also needs the WIF principal to hold the Secret Manager roles the current service account has. The commonpom 4.0.3+ prerequisite does not apply here: this repo has no io.extenda.maven:commonpom parent since #86, and the Maven deploy authenticates to Maven Central with the MAVEN_CENTRAL_* and GPG secrets rather than to GCP.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grant workflow-level
id-token: writein release.yaml and pull_request.yaml so the jobs calling extenda/actions/* can request an OIDC token from GitHub. The release job already re-declared it alongsidecontents: write; job-level blocks replace rather than merge, so that one stays as-is.The extenda wrappers pick their auth mode from the contents of the service-account-key value -- either a legacy
private_keyJSON key or aworkload_identity_providerfederation config. SECRET_AUTH currently holds a legacy key, so this permission is groundwork only. The migration completes when SECRET_AUTH is swapped to a WIF cred-config on the GCP side, which also needs the WIF principal to hold the Secret Manager roles the current service account has.