improve ci workflow#116
Open
bjohansebas wants to merge 12 commits into
Open
Conversation
bjohansebas
force-pushed
the
windows
branch
2 times, most recently
from
e8b618f to
bf9ac32
Compare
bjohansebas
force-pushed
the
windows
branch
7 times, most recently
from
3d4b9f3 to
03db43a
Compare
Member
Yep! It is good idea 👍 |
bjohansebas
force-pushed
the
windows
branch
3 times, most recently
from
c0fd80a to
4413378
Compare
Member
Author
|
It complicates the CI a lot, we could do it once we drop support for older Node.js versions. Do you have any plans to do that? |
Member
Author
|
cc: @UlisesGascon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows is added to the CI support, removing Appveyor.
Do we probably want to run tests on macOS? Since it works with files.