fix: protect method names from token registration collisions#359
Open
baima365-web wants to merge 1 commit into
Open
fix: protect method names from token registration collisions#359baima365-web wants to merge 1 commit into
baima365-web wants to merge 1 commit into
Conversation
Prevent token registration from overwriting module methods (token,
format, compile) by making them non-writable. Previously, calling
morgan.token('token', fn) would overwrite the morgan.token() method,
breaking subsequent token registrations.
Fixes expressjs#265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Calling
morgan.token('token', fn)overwrites themorgan.token()method itself, breaking all subsequent token registrations. This is becausemorganserves as both the module export (with methodstoken,format,compile) and the token registry.Example:
Fix
Make the
token,format, andcompilemethods non-writable usingObject.defineProperties. This prevents user token registrations from overwriting the module API while maintaining full backward compatibility.Test plan