fix: respect NO_COLOR environment variable in dev format#353
Open
luisangelrod wants to merge 1 commit into
Open
fix: respect NO_COLOR environment variable in dev format#353luisangelrod wants to merge 1 commit into
luisangelrod wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
devformat currently outputs ANSI color escape codes unconditionally. This ignores the widely-adoptedNO_COLORconvention, which signals that terminal color output is unwanted (accessibility, log pipelines, CI environments, etc.).Changes
index.js'NO_COLOR' in process.envbefore compiling the dev format stringNO_COLORis set, compile a plain format string (no ANSI codes) cached at key'plain'NO_COLORis absenttest/morgan.jswith NO_COLOR environment variabledescribe block with two tests: 2xx and 5xx status codes both produce output free of ANSI escape sequencesTesting
Closes #302