docs: clarify routing callback execution#2165
Merged
Merged
Conversation
Signed-off-by: greenbasket-labs <greenbasketgloball@gmail.com>
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Thanks for reviewing! Happy to make any adjustments if needed. |
krzysdz
suggested changes
Jun 21, 2026
krzysdz
left a comment
krzysdz
left a comment
Contributor
There was a problem hiding this comment.
Why does it modify English text in file that should be in Korean?
Member
|
It was the merge itself that caused that. I’m fixing it |
Reword the routing intro so it's explicit that Express runs the handler
automatically when a request matches the route and method, and fix the
singular/plural agreement ("a handler function").
Applies the change to the English sources (5x and 4x guides) with straight
quotes for consistency, instead of the Korean translation file (which is
Crowdin-managed).
bjohansebas
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies wording in the routing guide to explain that Express automatically executes route handler callbacks when a request matches a route and HTTP method. This improves clarity for beginners.