[eas-json][eas-cli] add support for refreshAdHocProvisioningProfile to iOS build profile configuration in eas.json#3886
Draft
sswrk wants to merge 1 commit into
Conversation
…o iOS build profile configuration in eas.json
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3886 +/- ##
==========================================
+ Coverage 58.92% 58.95% +0.03%
==========================================
Files 934 935 +1
Lines 40835 40857 +22
Branches 8607 8611 +4
==========================================
+ Hits 24058 24082 +24
+ Misses 16681 16679 -2
Partials 96 96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We support
--refresh-ad-hoc-provisioning-profilefor non-interactive iOS internal builds, but CI users had to pass the flag on every run. It will be useful to be able to make opt-in per-profileeas.jsonsetting instead. Global default staysfalse.How
eas-json: Add optionalios.refreshAdHocProvisioningProfileboolean toIosBuildProfile+ Joi schema.eas-cliresolve effective value looking at the CLI flag first, then, if not provided, at eas.json. Flag now usesallowNo: trueso--no-refresh-ad-hoc-provisioning-profilecan override an eas.jsontrue.CredentialsContext/SetUpAdhocProvisioningProfile/ iOS job prep paths.Test Plan
CI passes.