Skip to content

Use sjchmiela serve-sim previews without WebRTC#3885

Draft
sjchmiela wants to merge 5 commits into
mainfrom
stanley/rebase-serve-sim-preview-on-main
Draft

Use sjchmiela serve-sim previews without WebRTC#3885
sjchmiela wants to merge 5 commits into
mainfrom
stanley/rebase-serve-sim-preview-on-main

Conversation

@sjchmiela

Copy link
Copy Markdown
Contributor

Summary

  • switch remote device run sessions to the serve-sim-sjchmiela preview helper
  • report only the preview URL from serve-sim remote sessions
  • avoid forcing WebRTC for tunneled previews for now, keeping the AVCC/H.264 path with MJPEG fallback

Why

The live WebRTC preview path can get stuck during /webrtc/offer while the helper waits for server-side ICE gathering, leaving the browser simulator surface at connecting. The AVCC and MJPEG stream endpoints are healthy in that state, so this keeps the new helper while avoiding the broken WebRTC signaling path.

Test plan

  • yarn oxfmt --write packages/build-tools/src/steps/utils/remoteDeviceRunSession.ts packages/build-tools/src/steps/utils/__tests__/remoteDeviceRunSession.test.ts
  • yarn --cwd packages/build-tools jest-unit src/steps/utils/__tests__/remoteDeviceRunSession.test.ts
  • git diff --check main..HEAD

@github-actions

Copy link
Copy Markdown

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.93%. Comparing base (88a404e) to head (1fe93cb).

Files with missing lines Patch % Lines
...ld-tools/src/steps/utils/remoteDeviceRunSession.ts 66.67% 4 Missing ⚠️
.../src/steps/functions/startServeSimRemoteSession.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3885      +/-   ##
==========================================
+ Coverage   58.92%   58.93%   +0.02%     
==========================================
  Files         934      934              
  Lines       40835    40840       +5     
  Branches     8607     8607              
==========================================
+ Hits        24058    24066       +8     
+ Misses      16681    16678       -3     
  Partials       96       96              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant