Use sjchmiela serve-sim previews without WebRTC#3885
Draft
sjchmiela wants to merge 5 commits into
Draft
Conversation
|
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3885 +/- ##
==========================================
+ Coverage 58.92% 58.93% +0.02%
==========================================
Files 934 934
Lines 40835 40840 +5
Branches 8607 8607
==========================================
+ Hits 24058 24066 +8
+ Misses 16681 16678 -3
Partials 96 96 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serve-sim-sjchmielapreview helperWhy
The live WebRTC preview path can get stuck during
/webrtc/offerwhile the helper waits for server-side ICE gathering, leaving the browser simulator surface atconnecting. The AVCC and MJPEG stream endpoints are healthy in that state, so this keeps the new helper while avoiding the broken WebRTC signaling path.Test plan
yarn oxfmt --write packages/build-tools/src/steps/utils/remoteDeviceRunSession.ts packages/build-tools/src/steps/utils/__tests__/remoteDeviceRunSession.test.tsyarn --cwd packages/build-tools jest-unit src/steps/utils/__tests__/remoteDeviceRunSession.test.tsgit diff --check main..HEAD