Skip to content

[build-tools] Skip Xcode selection in development#3884

Merged
sjchmiela merged 1 commit into
mainfrom
stanley/skip-xcode-select-development
Jun 19, 2026
Merged

[build-tools] Skip Xcode selection in development#3884
sjchmiela merged 1 commit into
mainfrom
stanley/skip-xcode-select-development

Conversation

@sjchmiela

@sjchmiela sjchmiela commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This was needed for running in development where sudo is NOT passwordless and waits for password input.

Summary

  • skip sudo xcode-select for remote session startup when ENVIRONMENT=development
  • centralize Xcode developer directory selection for agent-device, Argent, and serve-sim remote sessions
  • run sudo xcode-select with stdin ignored and stdout/stderr piped to the step logger outside development

Test plan

  • yarn workspace @expo/build-tools test src/steps/utils/tests/remoteDeviceRunSession.test.ts
  • yarn workspace @expo/build-tools typecheck

@sjchmiela sjchmiela force-pushed the stanley/skip-xcode-select-development branch from 1f3a81f to eacb6b0 Compare June 19, 2026 10:59
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.91%. Comparing base (b2388fd) to head (eacb6b0).

Files with missing lines Patch % Lines
...ld-tools/src/steps/utils/remoteDeviceRunSession.ts 33.34% 6 Missing ⚠️
...c/steps/functions/startAgentDeviceRemoteSession.ts 0.00% 1 Missing ⚠️
...ls/src/steps/functions/startArgentRemoteSession.ts 0.00% 1 Missing ⚠️
.../src/steps/functions/startServeSimRemoteSession.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3884      +/-   ##
==========================================
- Coverage   58.92%   58.91%   -0.00%     
==========================================
  Files         934      934              
  Lines       40823    40825       +2     
  Branches     8606     8607       +1     
==========================================
- Hits        24051    24050       -1     
- Misses      16676    16679       +3     
  Partials       96       96              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Jun 19, 2026
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela sjchmiela marked this pull request as ready for review June 19, 2026 11:17
@sjchmiela sjchmiela requested a review from sswrk June 19, 2026 11:17
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sjchmiela sjchmiela merged commit 88a404e into main Jun 19, 2026
11 of 12 checks passed
@sjchmiela sjchmiela deleted the stanley/skip-xcode-select-development branch June 19, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants