fix(config): remove --api-key flag from omni config init - #65
Merged
Conversation
PR #63 added an --api-key flag for non-interactive setup. Accepting a secret on the command line leaks it into shell history and process listings (and from there into anything scraping them, including agentic tooling). Drop the flag and always read the key from a hidden prompt. The non-secret --name, --endpoint, and --auth flags remain, so the primary motivation — one-command non-interactive OAuth setup — still works. For api-key auth the key is now always read via term.ReadPassword, even when --auth api-key is supplied non-interactively. Removes the two tests that exercised the deleted flag. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EfZEjYSR3cRVTHgifwJYjK
n8agrin
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #63, which added an
--api-keyflag toomni config initfor non-interactive setup. Accepting a secret as a command-line argument leaks it into shell history and process listings — and from there into anything that scrapes those, including agentic tooling that can forward the token to LLM providers. This removes the--api-keyflag and always reads the key from a hidden prompt instead.The non-secret flags from #63 (
--name,--endpoint,--auth) are kept, so the primary motivation — one-command non-interactive OAuth setup — still works.🤖 Generated with Claude Code