Skip to content

fix(scripts): resolve CodeQL command-injection findings in generate-patch #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffreylouden merged 1 commit into from
Aug 20, 2026
+4 −4
Merged

fix(scripts): resolve CodeQL command-injection findings in generate-patch #635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/generate-patch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Run with: pnpm patch [from-version] [to-version]
*/

import { execSync } from "node:child_process";
import { execFileSync } from "node:child_process";
import fs from "node:fs";
import path from "node:path";
import { parse as parseYaml } from "yaml";
Expand Down Expand Up @@ -39,7 +39,7 @@ function buildManufacturerIdMap(): Map<string, string> {
/** Get the nanoid of a deleted entry by reading it from git history */
function getDeletedEntryId(since: string, filePath: string): string | null {
try {
const content = execSync(`git show ${since}:${filePath}`, {
const content = execFileSync("git", ["show", `${since}:${filePath}`], {
encoding: "utf-8",
stdio: ["pipe", "pipe", "pipe"],
});
Expand All @@ -56,7 +56,7 @@ function getDeletedEntryId(since: string, filePath: string): string | null {

function getLatestTag(): string | null {
try {
return execSync("git describe --tags --abbrev=0", {
return execFileSync("git", ["describe", "--tags", "--abbrev=0"], {
encoding: "utf-8",
stdio: ["pipe", "pipe", "pipe"],
}).trim();
Expand All @@ -70,7 +70,7 @@ function getChangedFiles(since: string): Change[] {

try {
// Get list of changed files
const output = execSync(`git diff --name-status ${since} HEAD -- data/`, {
const output = execFileSync("git", ["diff", "--name-status", since, "HEAD", "--", "data/"], {
encoding: "utf-8",
});

Expand Down