Skip to content

Update the crypto-square proof to pass with node 24 #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SleeplessByte merged 1 commit into from
Jul 24, 2026
Merged

Update the crypto-square proof to pass with node 24 #1646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions exercises/practice/crypto-square/.meta/proof.ci.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@ export class Crypto {
}

const splitRegex = new RegExp(`.{1,${chunkSize}}`, 'g')
return this.ciphertextSegments()
.join('')
.match(splitRegex)
.map((item) => item.padEnd(chunkSize, ' '))
.join(' ')
const segments = this.ciphertextSegments() ?? []
const chunks = segments.join('').match(splitRegex) ?? []
return chunks.map((item) => item.padEnd(chunkSize, ' ')).join(' ')
}

public get size(): number {
Expand All @@ -25,7 +23,7 @@ export class Crypto {
}

private ciphertextSegments(): string[] {
const textSegments = this.plaintextSegments()
const textSegments = this.plaintextSegments() ?? []
const columns: string[][] = []
let i: number
let j: number
Expand Down Expand Up @@ -53,7 +51,7 @@ export class Crypto {
return result
}

private plaintextSegments(): RegExpMatchArray {
private plaintextSegments(): RegExpMatchArray | null {
const plainText = this.plaintext
const chunkSize = this.size

Expand Down
Loading