Last Will exercise + namespaces#1832
Open
VaiaPatta1985 wants to merge 17 commits into
Open
Conversation
The tests for these two learning exercises now check whether the expected exception has been defined inside or outside the main class. Solves issue #6772
The tests for these two learning exercises now check whether the expected exception has been defined inside or outside the main class. Solves issue #6772
…o moviegoer_calculator_fix
kotp
requested changes
May 13, 2026
Member
kotp
left a comment
kotp
left a comment
There was a problem hiding this comment.
Ensure consistent formatting of the code and the code snippets.
Inspect the reasons for the failing CI tasks/checks.
kotp
reviewed
May 13, 2026
| def test_regular_moviegoers_dont_get_free_popcorn | ||
| assert_raises NotMovieClubMemberError do | ||
| expected_exception = Moviegoer.include?(NotMovieClubMemberError) ? Moviegoer::NotMovieClubMemberError : NotMovieClubMemberError | ||
| assert_raises expected_exception do |
Member
There was a problem hiding this comment.
The moviegoer and simple calculator changes do not belong in this patch. You will likely need to update your main branch for your repository, and rebase these changes on to the current main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted the Last Will exercise from the C++ track and added it to the Ruby learning track, together with the concept of namespaces.