Skip to content

Add the documents an outside contributor needs - #1

Merged
ewraj merged 1 commit into
mainfrom
chore/contributor-docs
Sep 22, 2026
Merged

ewraj merged 1 commit into
mainfrom
chore/contributor-docs

Conversation

@ewraj

@ewraj ewraj commented Sep 17, 2026

Copy link
Copy Markdown
Owner

What this changes

Adds CONTRIBUTING.md, .github/CODEOWNERS, .github/pull_request_template.md and SECURITY.md, and links the first two from the README alongside a local-setup block.

Does it make reading and understanding code better?

Indirectly — it protects the product that does. The gist refuses a long list of features, and right now the only way a contributor discovers that is by having a pull request declined after writing it.

How it was tested

  • npm run typecheck
  • npm test
  • npm run build

Documentation only; no source files touched. This PR is also the first end-to-end exercise of the new main ruleset — required verify check, linear history, squash or rebase only.

Anything reviewers should look at closely

  • CODEOWNERS entries are advisory right now. They request review automatically but do not require it until "require review from Code Owners" is turned on in the ruleset.
  • The declined list in CONTRIBUTING.md is drawn from the gist and IMPLEMENTATION_PLAN.md §13. Worth checking it matches what you actually intend to refuse.
  • SECURITY.md points at GitHub private advisories rather than an email address, so no personal address is published.

  • I have read CONTRIBUTING.md
  • This is one concern, not several

The repository asks for contributions but never said what it wants from
them, which for a project this opinionated is the expensive gap: the gist
refuses a long list of features, and someone can only find that out by
having a pull request declined.

CONTRIBUTING.md leads with the governing test - does this make reading and
understanding code better - and then states plainly what will be declined and
why, so that conversation happens before the code is written rather than
after. It also records the two things CI cannot check: stylus feel, and
whether ink stays welded to the text while scrolling.

CODEOWNERS routes review by blast radius rather than by file count. The gist
and the plan are direction, not implementation. Anchoring decides where
somebody's handwriting ends up. Workflows and lockfiles can publish to the
live site.

SECURITY.md sends reports to a private advisory instead of a public issue,
and describes where the risk actually is: no backend, no accounts, no token,
and code that is rendered but never executed. The surface worth probing is
the untrusted repository content the app renders.
@ewraj
ewraj merged commit 9cfe7e0 into main Sep 22, 2026
1 check passed
@ewraj
ewraj deleted the chore/contributor-docs branch September 22, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant