Move from react-router to wouter#873
Merged
Merged
Conversation
loichuder
force-pushed
the
migrate-to-wouter
branch
from
0e08180 to
4273924
Compare
loichuder
commented
Jun 29, 2026
| to={{ | ||
| pathname: '/edit', | ||
| search: state?.workflow | ||
| to={`/edit${ |
Member
Author
There was a problem hiding this comment.
wouter does not add aria-current by default so I created a new wrapper component to do it according to https://github.com/molefrog/wouter/blob/v3/packages/wouter/src/use-browser-location.js#how-do-i-make-a-link-active-for-the-current-route
loichuder
force-pushed
the
migrate-to-wouter
branch
2 times, most recently
from
61d7594 to
e9d86f0
Compare
loichuder
commented
Jun 29, 2026
axelboc
requested changes
Jun 29, 2026
loichuder
force-pushed
the
migrate-to-wouter
branch
from
e9d86f0 to
5400fc3
Compare
axelboc
approved these changes
Jun 30, 2026
| return ( | ||
| <Link | ||
| className={styles.link} | ||
| aria-current={isActive ? 'true' : undefined} |
Contributor
There was a problem hiding this comment.
FYI, I typically use the syntax isActive || undefined but that's fine
Member
Author
There was a problem hiding this comment.
Yup. Reads much better.
Don't hesitate to point stuff like this, my TS is a bit rusty
loichuder
force-pushed
the
migrate-to-wouter
branch
from
5400fc3 to
bf3c82d
Compare
Member
Author
|
Thanks for the great review! |
loichuder
force-pushed
the
migrate-to-wouter
branch
from
bf3c82d to
3bc7ff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #869