642 - SL5b-V1 — Holon space membership - #663
Open
nphias wants to merge 1 commit into
Open
Conversation
nphias
marked this pull request as ready for review
August 26, 2026 16:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every published lineage acquires
OwnedBy → current HolonSpace; commit materializes theOwnsinverse on the space. Membership is queryable by ordinary traversal.
GetAllHolonsis untouched— it still reads
AllHolonNodes. No consumer-visible behavior change.Changes
commit_functions.rsstage_space_membership, called fromcommit_holon'sForCreatearm afterpersist_holonso the new lineage's id is available to the self-ownership guard. Warns rather than skipping silently when no space is bound.staged.rsRelationshipCommitScope::FullExceptMembership+ setter, so a version-producing commit doesn't re-anchor membership;OwnedByordered first underFullso a failing user relationship can't preempt it.inverse_resolution.rsOwnedBy → Ownsshort-circuit.resolve_inversegoes through the source'sDescribedBy, which undescribed holons and the first core-schema load don't have.guest_holon_service.rsretract_space_membershipon delete. Reader left onAllHolonNodes— the repoint is V2.execution_reference.rsassert_saved_content_eqtreatsOwnedByas infrastructure-supplied, not fixture-authored.test_steps,adders,dance_tests, 2 new files)VerifySpaceMembershipstep + executor +space_membership_fixture.Tests
space_membership_fixtureasserts create, independent clone, and delete — exact member keys, bothdirections (
Ownson the space,OwnedByback to it). Confirmed to fail with the stamp disabled.Full
npm run sweetestexit 0: 63 tests, 0 failed, 2 ignored, audit passed.holons_core315.All three workspace checks clean.
Self-containment check passes: zero churn in the count fixtures,
constants.rs, or anycontract/SDK/TDL doc. All of that is V2.
Three notes
Version leg deferred. Staging a new version stages
Predecessor, whose inverse resolvesthrough
DescribedBy— so version-producing commits need a described holon, and this fixtureis deliberately schema-free.
add_verify_space_membership_count_stepexists for schema-backedfixtures; wiring it into
stage_new_version_fixturewould close this. Thestaged.rsunit testcovers the mechanism meanwhile.
Two pre-existing bugs found, not caused by V1.
related_holons(Owns)on the space returnsempty even when the link exists (inverse name, anchor has no
DescribedBy);all_related_holons()finds it. And
GetAllHolonserrors after a delete, because the index still lists the deletedholon — the same limitation that had
delete_holon_fixture's assertion commented out. V2 fixesthe second by construction. The executor sidesteps both by deriving the space from a member's
OwnedBy.Open
The
Ownsfan-in cost is still unmeasured — every inverse link is based on the space holon, andput_smartlinkscans that base, so a 191-holon schema load is ~O(n²) tag decodes. Belongs to V1since this is where the writes are introduced. Baseline by checking out the parent commit, not by
stashing.