Skip to content

Fix flaky getOrUpdateOpt test #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stasimus wants to merge 2 commits into from
Open

Fix flaky getOrUpdateOpt test #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1e2c4f
Remove racy waiter from getOrUpdateOpt test
stasimus Sep 3, 2026
83816ac
Make getOrUpdateOpt test fully sequential
stasimus Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions scache/src/test/scala/com/evolution/scache/CacheSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,16 +456,12 @@ class CacheSpec extends AsyncFunSuite with Matchers {

check(s"getOrUpdateOpt: $name") { (cache, metrics) =>
for {
deferred <- Deferred[IO, Option[Int]]
value0 <- cache.getOrUpdateOptEnsure(0) { deferred.get }
value1 <- cache.getOrUpdateOpt(0)(0.some.pure[IO]).startEnsure
_ <- deferred.complete(none)
value0 <- value0.joinWithNever
value1 <- value1.joinWithNever
_ = value0 shouldEqual none[Int].asRight
_ = value1 shouldEqual none[Int]
value <- cache.getOrUpdateOpt(0)(0.some.pure[IO])
_ = value shouldEqual 0.some
value <- cache.getOrUpdateOpt(0) { none[Int].pure[IO] }
_ <- IO { value shouldEqual none[Int] }
value <- cache.getOrUpdateOpt(0) { 0.some.pure[IO] }
_ <- IO { value shouldEqual 0.some }
value <- cache.getOrUpdateOpt(0) { 1.some.pure[IO] }
_ <- IO { value shouldEqual 0.some }
_ <- metrics.expect(
metrics.expectedGet(hit = false) -> 2,
metrics.expectedGet(hit = true) -> 1,
Expand Down
Loading