Skip to content

Report cancelled loads in load metrics - #387

Open
stasimus wants to merge 1 commit into
fix-flaky-getOrUpdateOptfrom
cancelled-load-metrics
Open

stasimus wants to merge 1 commit into
fix-flaky-getOrUpdateOptfrom
cancelled-load-metrics

Conversation

@stasimus

@stasimus stasimus commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Closes #386.

A load cancelled while running left no trace in cache_load_result and cache_load_time. CacheMetered now reports it with result=cancelled and the time spent until cancellation. CacheMetrics.load takes a LoadResult (success, failure, cancelled); the Boolean overload stays as a deprecated forwarder.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: evolution-gaming/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d9d1496b-a056-4585-ab38-abbb22bcd791

📥 Commits

Reviewing files that changed from the base of the PR and between 83816ac and 6c1a1bb.

📒 Files selected for processing (5)
  • build.sbt
  • scache/src/main/scala/com/evolution/scache/CacheMetered.scala
  • scache/src/main/scala/com/evolution/scache/CacheMetrics.scala
  • scache/src/test/scala/com/evolution/scache/CacheMeteredSpec.scala
  • scache/src/test/scala/com/evolution/scache/CacheSpec.scala

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@stasimus
stasimus marked this pull request as draft September 3, 2026 12:10

@mr-git mr-git left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising, though very hard to review with changes from #369 interleaved.

Shall we try the "Stacked PRs" feature?

@stasimus
stasimus force-pushed the cancelled-load-metrics branch from c59c07d to 82c5161 Compare September 3, 2026 12:19
@mr-git

mr-git commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

hm.. one unit-test is failing...

@stasimus
stasimus marked this pull request as ready for review September 3, 2026 15:50
@stasimus
stasimus force-pushed the cancelled-load-metrics branch from 82c5161 to d55fa7b Compare September 3, 2026 19:23
@stasimus
stasimus changed the base branch from experimenting to fix-flaky-getOrUpdateOpt September 3, 2026 19:25
@stasimus
stasimus force-pushed the cancelled-load-metrics branch from f3e5f16 to 6c1a1bb Compare September 30, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add metrics for cancelled loads

2 participants