Repository navigation
Bulk dependency update - #31
Conversation
…ts, cats-helper-logback, smetrics, sbt
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: evolution-gaming/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe dynamic key-value reader now uses ChangesDynamic key-value reader
Build and dependency updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The dynamic reader is initialized before use, and the dependency changes show no concrete compatibility failure in the inspected APIs. No user-facing regression is established; normal build and CI checks should still confirm readiness. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 6 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There are some changes in JNATS public API which should be added to our |
|
@DeviLab I assume this can be done in a separate pull request. This change is about updating the dependencies rather than keeping the |
|
Looks logical to either
|
|
Bumping JNATS without updating API for new features has very little sense and increases a technical debt. The simplest way to update API is exactly during dependencies updates because the changelog is reviewed anyway. I don't mind if JNATS version will be bumped later, but I'm not okay that the API in master is not synchronized with JNATS and there is no clear plan/intention to fix it. |
You can't control whether jnants will be updated in consumer projects. If it is updated by a consumer, the features you want to keep in sync won't be received, hence your statement "has very little sense"
I reverted the update and added a comment so you can do a bump later |
kromanovs
left a comment
There was a problem hiding this comment.
Looks good to me now without the jnats bump
|
I can't control whether JNATS will be updated, but it's clearly mentioned in README.MD that backward compatibility is not guaranteed if the version is changed manually:
|
Updated:
Skipped:
Notable changes:
com.evolutiongaming:smetrics2.3.4 -> 3.0.0: applied the major bump directly. The release notes document no breaking API changes.org.typelevel:weaver-cats0.10.1 -> 0.13.0: upstream renamed several APIs across this range (MutableIOSuitetoIOSuite,ExpectationFailedtoExpectationsFailed,Suite[F]toEffectSuite[F]; see the release notes). This project doesn't reference any of the renamed symbols, so it compiled without changes.io.nats:jnats2.25.1 -> 2.26.3:Options.Builder#enableFastFallbackis now deprecated. Migrated tohostnameResolveMode(HostnameResolveMode.HappyEyeballs)incore/.../impl/package.scala.org.typelevel:cats-effect3.6.3 -> 3.7.1:cats.effect.std.Hotswapis now deprecated in favor ofNonEmptyHotswap. MigratedDynamicKeyValueReaderto the new API, which also drops theOptionhandling sinceNonEmptyHotswapalways holds a value.Changelogs
Summary by CodeRabbit