Skip to content

fix: add read/write timeouts to the RDP connection (remote hang) #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evilsocket merged 1 commit into from
Jul 6, 2026
Merged

fix: add read/write timeouts to the RDP connection (remote hang) #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/plugins/rdp/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,15 @@ impl Plugin for RDP {
.map_err(|e| e.to_string())?;

let stream = TcpStream::connect_timeout(&address, timeout).map_err(|e| e.to_string())?;
// connect_timeout only bounds the connect; without these a malicious or silent RDP
// server would hang the operator's thread during the handshake reads in
// Connector::connect (blocking, synchronous socket).
stream
.set_read_timeout(Some(timeout))
.map_err(|e| e.to_string())?;
stream
.set_write_timeout(Some(timeout))
.map_err(|e| e.to_string())?;

let mut rdp_connector = Connector::new()
.screen(800, 600)
Expand Down
Loading