Add real_world_MatanDanOn#225
Open
MatanDanOn wants to merge 2 commits into
Open
Conversation
evidencebp
requested changes
Jun 16, 2026
evidencebp
left a comment
evidencebp
left a comment
Owner
There was a problem hiding this comment.
Please check the file content.
Github identifies it as a binary file, not a csv.
Contributor
Author
|
The issue may have been macOS insisting on exporting the file in a numbers format rather than a csv, hopefully it'll go smoothly now |
evidencebp
requested changes
Jun 16, 2026
| unit_type varchar(255), | ||
| record_date date NOT NULL, | ||
| amount bigint NOT NULL, | ||
| tracking_id varchar(128) NOT NULL,",Data Integrity,"The 'unit_type' and 'subscription_id' columns are logically required for the application to function correctly, but the table schema allows them to accept NULL values.",Add 'NOT NULL' constraints to both 'unit_type' and 'subscription_id' columns in the table definition.,"CREATE TABLE rolled_up_usage ( |
Owner
There was a problem hiding this comment.
This question requires context.
It will be unfair to give it in a test.
Repllace with a contextless question.
| id SERIAL PRIMARY KEY, | ||
| editor_id INT NOT NULL, | ||
| bbid UUID NOT NULL | ||
| );",Data Integrity,"Editor_id and bbid aren’t constrained to be unique, which may cause data integrity issues as they are ID columns.",Add a unique constraint for both columns.,"CREATE TABLE bookbrainz._editor_entity_visits ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.