Repository navigation
fix: playback resume quality, client-cancel errors, render-stall false alarms, series enrich race, read-ratio counters - #111
Merged
Conversation
…a bandwidth step switches after the buffer instead of flushing it
… a resume after a pause is no render slowdown, concurrent writes keep an item's trailers, a busy scan is no watcher error, and a missing media item is logged with its id
…ver int, WaitGroup.Go, require.ErrorIs)
… (guarded), a hidden tab is no render slowdown, and a new series is enriched once for all its seasons and episodes
…rror instead of discarding it
…ns, the slot waits, the stream fallbacks and the plan's Stat calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web player
preserveManualLevelOnErroris set, which handed playback to the free ABR the player keeps off.loadLevel(after the buffer) instead ofcurrentLevel(flush): no stall and one encoder per rung instead of two. The viewer's own pick and a render cap still switch at once.Server
internalError, so a client that gave up answersCanceled(DEBUG) instead ofInternal(ERROR + 5xx). A contract guard refuses the hand-written form.media_trailers_pkey; the seasons and episodes of a new series share one enrichment of the series (singleflight).GetMediaItemnot-found WARN carries the item id.Tests
Each fix has a test that was red before it: hls.js config, resume cancel codes, trailer race on a real Postgres (8 concurrent writers), busy-scan log level, render-stall pause and hidden tab, series enrich count (6 searches to 1), Stat counter (integration).
make gategreen on the head.