Skip to content

fix(players): the profile's subtitle style wins over the device's, a pending style change survives leaving the screen, and the audio renegotiation is one per media - #107

Merged
gravity-zero merged 1 commit into
devfrom
fix/subtitle-style-profile-wins
Nov 18, 2026

Conversation

@gravity-zero

Copy link
Copy Markdown
Contributor
  • TV and mobile: the style stored on the profile is applied over the device's last value, which only fills in when the profile never chose one.
  • usePlayerProfilePrefs: a style change still inside its save delay is sent when the player unmounts instead of being dropped, and never sent twice.
  • TV and mobile: the one-shot audio fallback renegotiation resets on each new media, so the next title can renegotiate again.

Tests: usePlayerProfilePrefs (debounced save, flush on unmount, no double send), TV player (renegotiates again on the next media, keeps the profile's style over this device's last value). make gate green on aac1eaa.

…pending style change survives leaving the screen, and the audio renegotiation is one per media
@gravity-zero
gravity-zero merged commit 789718e into dev Nov 18, 2026
9 checks passed
@gravity-zero
gravity-zero deleted the fix/subtitle-style-profile-wins branch November 18, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant