Repository navigation
fix(transcode): an unmeasured audio layout holds to the profile's channel cap, so its variants resolve the fingerprint the master sealed - #106
Merged
Conversation
…nel cap, so its variants resolve the fingerprint the master sealed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the source audio layout was never probed, the decision kept the client's channel ceiling and ignored the profile's lower one. The master sealed one fingerprint and the variants derived another, so every variant request answered 410 and the player retried in a loop.
The unknown-layout branch now takes the lower of the client and profile ceilings, the same rule as the measured path.
Tests: TestUnknownLayout_HoldsTheLowerCeiling (decision) and TestUnknownLayout_ProfileCap_VariantResolvesTheSealedFingerprint (HTTP, master then variant, with the measured 5.1 case as control). make gate green on 977094d.