Skip to content

feat(subtitles): VobSub, DVB and picture sidecars drawn by the players - #105

Merged
gravity-zero merged 18 commits into
devfrom
feat/bitmap-subtitles-vobsub-dvb
Nov 18, 2026
Merged

gravity-zero merged 18 commits into
devfrom
feat/bitmap-subtitles-vobsub-dvb

Conversation

@gravity-zero

Copy link
Copy Markdown
Contributor

VobSub (DVD) and DVB subtitle tracks, and picture subtitle files beside the video (.sup, .idx/.sub), are now drawn by the players like PGS instead of being burnt in.

  • mkvgo v0.69.0 reads and times the pictures: embedded tracks through matroska.ForEachSubtitleBitmap[From] (from the subtitle index when there is one), sidecars through matroska.ForEachSubtitleBitmapFile. A damaged region or a picture that does not decode costs only its own cues; a track where every picture fails is an error and the failure is remembered.
  • Served in the same EVEYPGS1 blob as PGS; bitmapServable replaces pgsServable and agrees with the client list (test reads imageSubtitles.ts).
  • Sidecars: .sub paired in any letter case and through symlinks, cache key covers both files, one shared decode per file, failure memo.
  • Clients: a picture subtitle is drawn only from Matroska or a sidecar; in .ts, AVI or MP4 it is burnt in like XSUB (container from streamInfo.container). A sidecar is never burnt in by the transcode decision.
  • Prewarm indexes every picture track again, not only PGS.
  • Docs: docs/playback/subtitles.md and its five translations.

Verified: make verify-commit REF=19d7e6370 FRONTEND=1 green; golangci-lint 0 issues on the changed package; Evey's blob matched mkvgo's own readers byte for byte on the VobSub, DVB, damaged and sidecar fixtures before the switch.

… track its own pictures, not the whole track
@gravity-zero
gravity-zero merged commit 14288b7 into dev Nov 18, 2026
11 checks passed
@gravity-zero
gravity-zero deleted the feat/bitmap-subtitles-vobsub-dvb branch November 18, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant