Repository navigation
feat(subtitles): VobSub, DVB and picture sidecars drawn by the players - #105
Merged
Merged
Conversation
… instead of burning them in
…video as decoded images
…nstead of walking the file
… track its own pictures, not the whole track
…he file's container
…nd key it on its .sub too
…urnt elsewhere, and read from the index
…able codec list against the server
…ock carries a duration
…rs and drop the local assembly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VobSub (DVD) and DVB subtitle tracks, and picture subtitle files beside the video (
.sup,.idx/.sub), are now drawn by the players like PGS instead of being burnt in.matroska.ForEachSubtitleBitmap[From](from the subtitle index when there is one), sidecars throughmatroska.ForEachSubtitleBitmapFile. A damaged region or a picture that does not decode costs only its own cues; a track where every picture fails is an error and the failure is remembered.EVEYPGS1blob as PGS;bitmapServablereplacespgsServableand agrees with the client list (test readsimageSubtitles.ts)..subpaired in any letter case and through symlinks, cache key covers both files, one shared decode per file, failure memo..ts, AVI or MP4 it is burnt in like XSUB (container fromstreamInfo.container). A sidecar is never burnt in by the transcode decision.docs/playback/subtitles.mdand its five translations.Verified:
make verify-commit REF=19d7e6370 FRONTEND=1green; golangci-lint 0 issues on the changed package; Evey's blob matched mkvgo's own readers byte for byte on the VobSub, DVB, damaged and sidecar fixtures before the switch.