fix(rg): align -u ignore classes with --no-ignore#1751
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | d6b2135 | Commit Preview URL | May 25 2026, 04:33 PM |
When -u/--unrestricted is first applied (level 1) it now disables all per-class ignore toggles (no_ignore_dot, no_ignore_exclude, no_ignore_global, no_ignore_parent, no_ignore_vcs) in addition to no_ignore, matching real ripgrep behavior. This way later positive flags such as --ignore-dot can re-enable only their intended class. Adds a differential regression case '-u --ignore-dot'. Rebased on current main on top of #1754; original PR #1751 by chaliy.
chaliy
force-pushed
the
2026-05-25-fix-rg-ignore-class-toggles-in-u-flag
branch
from
58c8fe9 to
d6b2135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
-u/--unrestrictedmatch--no-ignoresemantics by disabling all per-class ignore toggles on the first-uso later positive flags only re-enable their intended classes.-u --ignore-dotunintentionally left VCS/exclude/global/parent ignore classes enabled, causing incorrect ignore-file loading.Description
RgOptions::apply_unrestrictedto setno_ignore_dot,no_ignore_exclude,no_ignore_global,no_ignore_parent, andno_ignore_vcswhenno_ignoreis first set.unrestricted and ignore-dot only restores dot ignoresto prevent regressions in partial re-enable behavior.crates/bashkit/src/builtins/rg/mod.rs.Testing
cargo test -p bashkit builtins::rg::tests -- --nocaptureand the test run exercised the rg suite; the new/related rg tests passed while one unrelated existing differential test (diff_rg_matches_real_rg_cases) failed due to a timing-line mismatch.-u --ignore-dotexecuted and matched the expected output in the test run.Codex Task